From 6c2821609c81050775e9fccf77030b16d3eddbe8 Mon Sep 17 00:00:00 2001 From: andersonid Date: Fri, 3 Oct 2025 09:41:02 -0300 Subject: [PATCH] Fix: pass time_range parameter to generate_recommendations for proper 7-day data --- app/api/routes.py | 2 +- app/services/historical_analysis.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/api/routes.py b/app/api/routes.py index 4b87caa..454265c 100644 --- a/app/api/routes.py +++ b/app/api/routes.py @@ -1469,7 +1469,7 @@ async def get_workload_historical_details( memory_data = await historical_service.get_memory_usage_history(namespace, workload, time_range) # Generate recommendations - recommendations = await historical_service.generate_recommendations(namespace, workload) + recommendations = await historical_service.generate_recommendations(namespace, workload, time_range) return { "workload": workload, diff --git a/app/services/historical_analysis.py b/app/services/historical_analysis.py index 61a8e9f..567b08b 100644 --- a/app/services/historical_analysis.py +++ b/app/services/historical_analysis.py @@ -1435,12 +1435,12 @@ class HistoricalAnalysisService: "error": str(e) } - async def generate_recommendations(self, namespace: str, workload: str) -> List[Dict[str, Any]]: + async def generate_recommendations(self, namespace: str, workload: str, time_range: str = "24h") -> List[Dict[str, Any]]: """Generate recommendations based on historical data""" try: # Get current usage data - cpu_data = await self.get_cpu_usage_history(namespace, workload, "24h") - memory_data = await self.get_memory_usage_history(namespace, workload, "24h") + cpu_data = await self.get_cpu_usage_history(namespace, workload, time_range) + memory_data = await self.get_memory_usage_history(namespace, workload, time_range) recommendations = []