Fix: pass time_range parameter to generate_recommendations for proper 7-day data
This commit is contained in:
@@ -1469,7 +1469,7 @@ async def get_workload_historical_details(
|
|||||||
memory_data = await historical_service.get_memory_usage_history(namespace, workload, time_range)
|
memory_data = await historical_service.get_memory_usage_history(namespace, workload, time_range)
|
||||||
|
|
||||||
# Generate recommendations
|
# Generate recommendations
|
||||||
recommendations = await historical_service.generate_recommendations(namespace, workload)
|
recommendations = await historical_service.generate_recommendations(namespace, workload, time_range)
|
||||||
|
|
||||||
return {
|
return {
|
||||||
"workload": workload,
|
"workload": workload,
|
||||||
|
|||||||
@@ -1435,12 +1435,12 @@ class HistoricalAnalysisService:
|
|||||||
"error": str(e)
|
"error": str(e)
|
||||||
}
|
}
|
||||||
|
|
||||||
async def generate_recommendations(self, namespace: str, workload: str) -> List[Dict[str, Any]]:
|
async def generate_recommendations(self, namespace: str, workload: str, time_range: str = "24h") -> List[Dict[str, Any]]:
|
||||||
"""Generate recommendations based on historical data"""
|
"""Generate recommendations based on historical data"""
|
||||||
try:
|
try:
|
||||||
# Get current usage data
|
# Get current usage data
|
||||||
cpu_data = await self.get_cpu_usage_history(namespace, workload, "24h")
|
cpu_data = await self.get_cpu_usage_history(namespace, workload, time_range)
|
||||||
memory_data = await self.get_memory_usage_history(namespace, workload, "24h")
|
memory_data = await self.get_memory_usage_history(namespace, workload, time_range)
|
||||||
|
|
||||||
recommendations = []
|
recommendations = []
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user